Name: code-review-asm-xtensa
Author: furballroller

Imported from furballroller/super_cat_game (arduino_sketches/cat_game/lib/FastLED-master/.claude/skills/code-review-asm-xtensa/SKILL.md). Install upstream with npx skills add furballroller/super_cat_game --skill code-review-asm-xtensa. Copyright stays with the author.

Perform comprehensive manual review of Xtensa assembly code in FastLED ESP32 platforms for correctness, ABI compliance, safety, and performance.

What Gets Checked

Critical Errors (Must Fix)

E001: Invalid movi for 32-bit addresses
E002: Wrong return instruction in interrupts
E003: Missing memw memory barriers for MMIO writes
E004: Windowed ABI used in interrupt handlers
E005: Unaligned memory access
E006: Missing IRAM_ATTR on interrupt handlers
E007: Mixed ABI usage in same function

Performance Warnings

W001-W005: Load-use hazards, loop overhead, nesting depth, register pressure, dependency chains

Optimization Opportunities

O001-O004: Array indexing, conditional moves, loop unrolling, code density

Search for Xtensa assembly code in git changes (inline asm and .S files) and perform deep analysis.

{ "ocm": "1", "id": "furballroller-super-cat-game-code-review-asm-xtensa", "kind": "skill", "name": "code-review-asm-xtensa", "description": "Review Xtensa assembly code for ESP32 platforms. Checks for critical errors in inline assembly, ABI compliance, and optimization opportunities. Use after modifying ESP32 assembly or inline asm code.", "publisher": "furballroller", "version": "1.0.0", "capabilities": { "domains": [ "coding", "legal" ], "tags": [ "skill-md", "github" ], "languages": [ "en" ] }, "quality_prior": 0.6, "examples": [ "Review Xtensa assembly code for ESP32 platforms. Checks for critical errors in inline assembly, ABI compliance, and optimization opportunities. Use after modifying ESP32 assembly or inline asm code." ], "primary": false, "metadata": { "source": { "provider": "github", "repository": "https://github.com/furballroller/super_cat_game", "path": "arduino_sketches/cat_game/lib/FastLED-master/.claude/skills/code-review-asm-xtensa/SKILL.md", "ref": "1d6f048bce68921092ad9c75aba787e0140a18cb", "url": "https://github.com/furballroller/super_cat_game/blob/1d6f048bce68921092ad9c75aba787e0140a18cb/arduino_sketches/cat_game/lib/FastLED-master/.claude/skills/code-review-asm-xtensa/SKILL.md", "key": "furballroller/super_cat_game/arduino_sketches/cat_game/lib/FastLED-master/.claude/skills/code-review-asm-xtensa/SKILL.md" } }, "instructions": "Perform comprehensive manual review of Xtensa assembly code in FastLED ESP32 platforms for correctness, ABI compliance, safety, and performance.\n\n## What Gets Checked\n\n### Critical Errors (Must Fix)\n- **E001**: Invalid `movi` for 32-bit addresses\n- **E002**: Wrong return instruction in interrupts\n- **E003**: Missing `memw` memory barriers for MMIO writes\n- **E004**: Windowed ABI used in interrupt handlers\n- **E005**: Unaligned memory access\n- **E006**: Missing `IRAM_ATTR` on interrupt handlers\n- **E007**: Mixed ABI usage in same function\n\n### Performance Warnings\n- **W001-W005**: Load-use haza", "cost": { "context_tokens": 221 } }

code-review-asm-xtensa

About

What Gets Checked

Critical Errors (Must Fix)

Performance Warnings

Optimization Opportunities

Use it

Manifest

Reviews