OpenSmartRoute

review-pr - Prompt - OpenSmartRoute

Promptv1.0.0

review-pr

Name: review-pr
Author: rupeshbhurke

Code review checklist for pull requests

by rupeshbhurke(0) 0 installs

Free

Free account. Installing gives you the manifest plus copy-paste snippets.

See reviews

About

Prompt file imported from rupeshbhurke/calm_board_games (.windsurf/workflows/review-pr.md). Copyright stays with the author.

/review-pr

Objective: Systematically review code changes for quality and consistency.

Review Process

Step 1: Understand the change

Read PR description
Identify files changed
Understand the purpose

Step 2: Check architecture compliance

Game modules in correct location (lib/lib/games/<game_id>/)
Logic separated from UI (no Flutter in logic/ dirs)
Module implements GameModule interface
Registration in GameRegistry only

Step 3: Check design system usage

Uses Spacing.* for all spacing values
Uses CalmPalette.* for all colors
Uses Spacing.r* for border radii
Uses Spacing.ms* for animation durations
Imports from design/tokens.dart

Step 4: Check code quality

Step 5: Check tests

Tests exist for new logic
Tests cover edge cases
Tests use deterministic RNG
All tests pass

Step 6: Run verification

// turbo

flutter analyze

// turbo

flutter test

Common Issues

Architecture Violations

Problem: Flutter imports in logic files

// BAD
import 'package:flutter/material.dart';

Fix: Remove Flutter imports, use pure Dart

Problem: Game not registered

// Missing in game_registry.dart
modules: const [
  // MyGameModule() not here
],

Fix: Add module to registry

Design System Violations

Problem: Hardcoded values

// BAD
padding: EdgeInsets.all(16),
color: Color(0xFF123456),

Fix: Use tokens

// GOOD
padding: EdgeInsets.all(Spacing.s13),
color: CalmPalette.primary,

Testing Issues

Problem: Non-deterministic tests

// BAD
final logic = GameLogic(); // Uses real RNG

Fix: Inject fake RNG

// GOOD
final logic = GameLogic(rng: _FakeRng(ints: [0, 1]));

Review Feedback Template

Approval

✅ LGTM

- Architecture: Correct
- Design tokens: Used consistently
- Tests: Passing
- Analysis: Clean

Request Changes

⚠️ Changes requested

**Architecture:**
- [ ] Issue 1

**Design System:**
- [ ] Issue 2

**Tests:**
- [ ] Issue 3

Please address and re-request review.

Verification Commands

// turbo

flutter analyze

// turbo

flutter test

flutter run -d chrome

Use it

Copy one of these into your project. Installing also returns the manifest and these snippets.

# /review-pr

**Objective:** Systematically review code changes for quality and consistency.

---

## Review Process

### Step 1: Understand the change

1. Read PR description
2. Identify files changed
3. Understand the purpose

### Step 2: Check architecture compliance

- [ ] Game modules in correct location (`lib/lib/games/<game_id>/`)
- [ ] Logic separated from UI (no Flutter in `logic/` dirs)
- [ ] Module implements `GameModule` interface
- [ ] Registration in `GameRegistry` only

### Step 3: Check design system usage

- [ ] Uses `Spacing.*` for all spacing values
- [ ] Uses `CalmPalette.*` for all colors
- [ ] Uses `Spacing.r*` for border radii
- [ ] Uses `Spacing.ms*` for animation durations
- [ ] Imports from `design/tokens.dart`

### Step 4: Check code quality

- [ ] No code duplication
- [ ] Immutable state classes
- [ ] No side effects in logic
- [ ] Proper error handling
- [ ] Clear naming conventions

### Step 5: Check tests

- [ ] Tests exist for new logic
- [ ] Tests cover edge cases
- [ ] Tests use deterministic RNG
- [ ] All tests pass

### Step 6: Run verification

// turbo
```bash
flutter analyze
```

// turbo
```bash
flutter test
```

---

## Common Issues

### Architecture Violations

**Problem:** Flutter imports in logic files
```dart
// BAD
import 'package:flutter/material.dart';
```

**Fix:** Remove Flutter imports, use pure Dart

---

**Problem:** Game not registered
```dart
// Missing in game_registry.dart
modules: const [
  // MyGameModule() not here
],
```

**Fix:** Add module to registry

---

### Design System Violations

**Problem:** Hardcoded values
```dart
// BAD
padding: EdgeInsets.all(16),
color: Color(0xFF123456),
```

**Fix:** Use tokens
```dart
// GOOD
padding: EdgeInsets.all(Spacing.s13),
color: CalmPalette.primary,
```

---

### Testing Issues

**Problem:** Non-deterministic tests
```dart
// BAD
final logic = GameLogic(); // Uses real RNG
```

**Fix:** Inject fake RNG
```dart
// GOOD
final logic = GameLogic(rng: _FakeRng(ints: [0, 1]));
```

---

## Review Feedback Template

### Approval

```
✅ LGTM

- Architecture: Correct
- Design tokens: Used consistently
- Tests: Passing
- Analysis: Clean
```

### Request Changes

```
⚠️ Changes requested

**Architecture:**
- [ ] Issue 1

**Design System:**
- [ ] Issue 2

**Tests:**
- [ ] Issue 3

Please address and re-request review.
```

---

## Verification Commands

// turbo
```bash
flutter analyze
```

// turbo
```bash
flutter test
```

```bash
flutter run -d chrome
```

Manifest

The prompt text and its fill-in variables. Copy it or fetch it by URL from your own code.

rupeshbhurke-calm-board-games-review-pr-workflow.prompt.jsonjson

{
  "prompt": "# /review-pr\n\n**Objective:** Systematically review code changes for quality and consistency.\n\n---\n\n## Review Process\n\n### Step 1: Understand the change\n\n1. Read PR description\n2. Identify files changed\n3. Understand the purpose\n\n### Step 2: Check architecture compliance\n\n- [ ] Game modules in correct location (`lib/lib/games/<game_id>/`)\n- [ ] Logic separated from UI (no Flutter in `logic/` dirs)\n- [ ] Module implements `GameModule` interface\n- [ ] Registration in `GameRegistry` only\n\n### Step 3: Check design system usage\n\n- [ ] Uses `Spacing.*` for all spacing values\n- [ ] Uses `CalmPalette.*` for all colors\n- [ ] Uses `Spacing.r*` for border radii\n- [ ] Uses `Spacing.ms*` for animation durations\n- [ ] Imports from `design/tokens.dart`\n\n### Step 4: Check code quality\n\n- [ ] No code duplication\n- [ ] Immutable state classes\n- [ ] No side effects in logic\n- [ ] Proper error handling\n- [ ] Clear naming conventions\n\n### Step 5: Check tests\n\n- [ ] Tests exist for new logic\n- [ ] Tests cover edge cases\n- [ ] Tests use deterministic RNG\n- [ ] All tests pass\n\n### Step 6: Run verification\n\n// turbo\n```bash\nflutter analyze\n```\n\n// turbo\n```bash\nflutter test\n```\n\n---\n\n## Common Issues\n\n### Architecture Violations\n\n**Problem:** Flutter imports in logic files\n```dart\n// BAD\nimport 'package:flutter/material.dart';\n```\n\n**Fix:** Remove Flutter imports, use pure Dart\n\n---\n\n**Problem:** Game not registered\n```dart\n// Missing in game_registry.dart\nmodules: const [\n  // MyGameModule() not here\n],\n```\n\n**Fix:** Add module to registry\n\n---\n\n### Design System Violations\n\n**Problem:** Hardcoded values\n```dart\n// BAD\npadding: EdgeInsets.all(16),\ncolor: Color(0xFF123456),\n```\n\n**Fix:** Use tokens\n```dart\n// GOOD\npadding: EdgeInsets.all(Spacing.s13),\ncolor: CalmPalette.primary,\n```\n\n---\n\n### Testing Issues\n\n**Problem:** Non-deterministic tests\n```dart\n// BAD\nfinal logic = GameLogic(); // Uses real RNG\n```\n\n**Fix:** Inject fake RNG\n```dart\n// GOOD\nfinal logic = GameLogic(rng: _FakeRng(ints: [0, 1]));\n```\n\n---\n\n## Review Feedback Template\n\n### Approval\n\n```\n✅ LGTM\n\n- Architecture: Correct\n- Design tokens: Used consistently\n- Tests: Passing\n- Analysis: Clean\n```\n\n### Request Changes\n\n```\n⚠️ Changes requested\n\n**Architecture:**\n- [ ] Issue 1\n\n**Design System:**\n- [ ] Issue 2\n\n**Tests:**\n- [ ] Issue 3\n\nPlease address and re-request review.\n```\n\n---\n\n## Verification Commands\n\n// turbo\n```bash\nflutter analyze\n```\n\n// turbo\n```bash\nflutter test\n```\n\n```bash\nflutter run -d chrome\n```",
  "variables": [],
  "notes": "Code review checklist for pull requests",
  "metadata": {
    "source": {
      "provider": "github-windsurf-workflows",
      "repository": "https://github.com/rupeshbhurke/calm_board_games",
      "path": ".windsurf/workflows/review-pr.md",
      "ref": "6304097297bc24cc2f88a956aaf5de8788af9eb6",
      "url": "https://github.com/rupeshbhurke/calm_board_games/blob/6304097297bc24cc2f88a956aaf5de8788af9eb6/.windsurf/workflows/review-pr.md",
      "key": "rupeshbhurke/calm_board_games/.windsurf/workflows/review-pr.md"
    }
  }
}

Fetch it by URL: GET /api/v1/registry/rupeshbhurke-calm-board-games-review-pr-workflow/manifest?version=1.0.0

About

/review-pr

Review Process

Step 1: Understand the change

Step 2: Check architecture compliance

Step 3: Check design system usage

Step 4: Check code quality

Step 5: Check tests

Step 6: Run verification

Common Issues

Architecture Violations

Design System Violations

Testing Issues

Review Feedback Template

Approval

Request Changes

Verification Commands

Use it

Manifest

Reviews